QPQ-AG/sophia
11
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Restructure and improve ACI #566

Merged
zxq9 merged 11 commits from fix_aci into master 2019-05-31 18:33:08 +09:00
Conversation 3 Commits 11 Files Changed 11 +455 -431
zxq9 commented 2019-05-28 20:35:25 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

  • Keyword indexed is now optional for word typed (bool, int, address,
    ...) event arguments.
  • State variable pretty printing now produce 'a, 'b, ... instead of '1, '2, ....
  • ACI is restructured and improved:
    • state and event types (if present) now appear at the top level.
    • Namespaces and remote interfaces are no longer ignored.
    • All type definitions are included in the interface rendering.
    • API functions are renamed, new functions are contract_interface
      and render_aci_json.
*Created by: hanssv* - Keyword `indexed` is now optional for word typed (`bool`, `int`, `address`, ...) event arguments. - State variable pretty printing now produce `'a, 'b, ...` instead of `'1, '2, ...`. - ACI is restructured and improved: - `state` and `event` types (if present) now appear at the top level. - Namespaces and remote interfaces are no longer ignored. - All type definitions are included in the interface rendering. - API functions are renamed, new functions are `contract_interface` and `render_aci_json`.
zxq9 commented 2019-05-28 21:26:15 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: UlfNorell

Review: Approved

*Created by: UlfNorell* **Review:** Approved
zxq9 commented 2019-05-31 17:43:04 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: happi

Review: Approved

*Created by: happi* **Review:** Approved
zxq9 commented 2019-05-31 18:33:08 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: hanssv at 2019-05-31 09:33:08 UTC

*Merged by: hanssv at 2019-05-31 09:33:08 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#566
No description provided.
Delete Branch "fix_aci"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?