QPQ-AG/sophia
11
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

docs: order namespaces alphabetically and place Set in includables #859

Merged
zxq9 merged 1 commits from docs/improve-stdlib-structure into master 2022-04-12 19:49:40 +09:00
Conversation 8 Commits 1 Files Changed 1 +1281 -1277
zxq9 commented 2022-02-04 09:26:24 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: marc0olo

I had to deal with Set recently and saw that it wasn't correctly placed in the includable namespaces section.

when fixing this I decided to sort everything alphabetically. makes sense IMO

*Created by: marc0olo* I had to deal with `Set` recently and saw that it wasn't correctly placed in the `includable namespaces` section. when fixing this I decided to sort everything alphabetically. makes sense IMO
ghallak (Migrated from gitlab.com) approved these changes 2022-02-04 09:26:24 +09:00
ghallak commented 2022-02-04 17:05:44 +09:00 (Migrated from gitlab.com)
Copy Link

I have added this <a name='set-stdlib'> because without it #set will direct you to Bits.set instead of Set

I have added this `<a name='set-stdlib'>` because without it `#set` will direct you to `Bits.set` instead of `Set`
ghallak commented 2022-02-04 17:07:09 +09:00 (Migrated from gitlab.com)
Copy Link

I see that you have deleted set-stdlib name from below. Are you sure that clicking this will direct you to the right place?

I see that you have deleted `set-stdlib` name from below. Are you sure that clicking this will direct you to the right place?
zxq9 commented 2022-02-04 20:42:34 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: marc0olo

good point, I re-added this as we have other sub-headings in the Bits section where set is already present. I fixed it now and tested locally

*Created by: marc0olo* good point, I re-added this as we have other sub-headings in the `Bits` section where `set` is already present. I fixed it now and tested locally
zxq9 commented 2022-02-04 20:43:17 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: marc0olo

yeah, should now work again with correct structure

*Created by: marc0olo* yeah, should now work again with correct structure
ghallak commented 2022-02-11 17:30:08 +09:00 (Migrated from gitlab.com)
Copy Link

approved this merge request

approved this merge request
zxq9 commented 2022-04-11 23:44:44 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2022-04-12 19:49:40 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: marc0olo at 2022-04-12 10:49:40 UTC

*Merged by: marc0olo at 2022-04-12 10:49:40 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
ghallak
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#859
No description provided.
Delete Branch "docs/improve-stdlib-structure"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?