QPQ-AG/sophia
11
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Add options to enable/disable certain optimizations #900

Merged
ghallak merged 5 commits from ghallak/271 into master 2022-08-30 16:14:46 +09:00
Conversation 4 Commits 5 Files Changed 3 +29 -15
ghallak commented 2022-08-27 01:57:52 +09:00 (Migrated from gitlab.com)
Copy Link

Fixes: #271

The following options are introduced:

  • optimize_inliner
  • optimize_inline_local_functions
  • optimize_bind_subexpressions
  • optimize_let_floating
  • optimize_simplifier
  • optimize_drop_unused_lets
  • optimize_scode

By default, all options are implicitly set to true, and they should be disabled separately by explicitly setting them to false.

Fixes: #271 The following options are introduced: - `optimize_inliner` - `optimize_inline_local_functions` - `optimize_bind_subexpressions` - `optimize_let_floating` - `optimize_simplifier` - `optimize_drop_unused_lets` - `optimize_scode` By default, all options are implicitly set to `true`, and they should be disabled separately by explicitly setting them to `false`.
zxq9 commented 2022-08-27 02:28:36 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

I don't like optimize_all. I would just set all of them to true by default - I would avoid inconsistent information

*Created by: radrow* I don't like optimize_all. I would just set all of them to true by default - I would avoid inconsistent information
zxq9 commented 2022-08-30 02:47:48 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2022-08-30 16:01:35 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2022-08-30 16:14:46 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: ghallak at 2022-08-30 07:14:46 UTC

*Merged by: ghallak at 2022-08-30 07:14:46 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#900
No description provided.
Delete Branch "ghallak/271"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?