QPQ-AG/sophia
11
0
Fork 0
Code Issues 41 Pull Requests 5 Actions Packages Projects Releases 16 Wiki Activity

Ban using contracts as namespaces #919

Merged
ghallak merged 5 commits from ghallak/412 into master 2022-11-23 18:03:24 +09:00
Conversation 6 Commits 5 Files Changed 5 +28 -1
ghallak commented 2022-11-18 23:16:21 +09:00 (Migrated from gitlab.com)
Copy Link

Fixes: #412

Fixes: #412
zxq9 commented 2022-11-21 16:46:15 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Mixing style, the previous clause uses , here we use orelse - consider ;?

*Created by: hanssv* Mixing style, the previous clause uses `,` here we use `orelse` - consider `;`?
zxq9 commented 2022-11-21 16:50:11 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Dismissed

👍

*Created by: hanssv* **Review:** Dismissed 👍
ghallak commented 2022-11-21 19:15:35 +09:00 (Migrated from gitlab.com)
Copy Link

Done here 3838a47694

Done here 3838a47694c2db10663ff79b7f54d4667e3fb9e1
zxq9 commented 2022-11-22 06:32:25 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: radrow

Review: Approved

*Created by: radrow* **Review:** Approved
zxq9 commented 2022-11-23 16:32:38 +09:00 (Migrated from gitlab.com)
Copy Link

Created by: hanssv

Review: Approved

*Created by: hanssv* **Review:** Approved
zxq9 commented 2022-11-23 18:03:24 +09:00 (Migrated from gitlab.com)
Copy Link

Merged by: ghallak at 2022-11-23 09:03:24 UTC

*Merged by: ghallak at 2022-11-23 09:03:24 UTC*
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
WIP
bug
consensus-breaking
dependencies
documentation
duplicate
effort: high
effort: low
effort: medium
effort: trivial
enhancement
good first issue
help wanted
invalid
maintenance
question
task/feature
todo-in-rewrite
wontfix
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
pig lipstick
Muggle-facing enhancements
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QPQ-AG/sophia#919
No description provided.
Delete Branch "ghallak/412"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?